fix apps menu not closing when the window is hidden, and make group folders menu...
authorJyrki Gadinger <nilsding@nilsding.org>
Wed, 8 Jan 2025 09:55:47 +0000 (10:55 +0100)
committerJyrki Gadinger <nilsding@nilsding.org>
Wed, 8 Jan 2025 09:55:47 +0000 (10:55 +0100)
this change resolves this ReferenceError when the window is being closed:
```
2025-01-08 10:56:40:389 [ warning default qrc:/qml/src/gui/tray/MainWindow.qml:100 ]:   qrc:/qml/src/gui/tray/MainWindow.qml:100: ReferenceError: appsMenu is not defined
```

I also noticed that the "Open local or group folders" dropdown menu
wouldn't show up due to this error:
```
2025-01-08 10:56:23:327 [ warning default qrc:/qml/src/gui/tray/TrayFoldersMenuButton.qml:33 ]: qrc:/qml/src/gui/tray/TrayFoldersMenuButton.qml:33: Error: Cannot call method QQuickPopup::open on QQuickLoader_QML_48(0x5569fb4648d0)
```
--> wrapped the calls to the open/close methods in a closure

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
src/gui/tray/MainWindow.qml
src/gui/tray/TrayFoldersMenuButton.qml
src/gui/tray/TrayWindowHeader.qml

index 482f65ea88b393568823d8fdd85b268b5f4bf712..a16b351ae8f70868020d306607f3fc0873b114aa 100644 (file)
@@ -100,8 +100,8 @@ ApplicationWindow {
 \r
             if (Systray.isOpen) {\r
                 trayWindowHeader.currentAccountHeaderButton.accountMenu.close();\r
-                appsMenu.close();\r
-                openLocalFolderButton.closeMenu()\r
+                trayWindowHeader.appsMenu.close();\r
+                trayWindowHeader.openLocalFolderButton.closeMenu()\r
             }\r
         }\r
 \r
index 6da6f9ca914cb16cdf66d1c08a5e9270359d9720..f98cad514b9204b4e454ab42c620cd662df86b6f 100644 (file)
@@ -222,8 +222,8 @@ HeaderButton {
             }
 
             Component.onCompleted: {
-                foldersMenuLoader.openMenu = open
-                foldersMenuLoader.closeMenu = close
+                foldersMenuLoader.openMenu = function() { open() }
+                foldersMenuLoader.closeMenu = function() { close() }
             }
 
             Connections {
index 10080212c1f56e3a5c05d86d3b6b976a8864d6c0..9ba808e5b7019d1362083a6c1f673ea390022d2d 100644 (file)
@@ -26,6 +26,8 @@ Rectangle {
     id: root
 
     readonly property alias currentAccountHeaderButton: currentAccountHeaderButton
+    readonly property alias openLocalFolderButton: openLocalFolderButton
+    readonly property alias appsMenu: appsMenu
 
     color: Style.currentUserHeaderColor